Skip to content

Fix #3 add Windows support #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
michaelherger wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix #3 add Windows support #4

michaelherger wants to merge 1 commit into from

Conversation

@michaelherger
Copy link

@michaelherger michaelherger commented Jan 23, 2025

No description provided.

@michaelherger michaelherger requested a review from a team as a code owner January 23, 2025 11:37
@michaelherger michaelherger requested review from denizsurmeli and sonmezonur and removed request for a team January 23, 2025 11:37
michaelherger added a commit to LMS-Community/slimserver that referenced this pull request Jan 23, 2025
@michaelherger
Add Windows support for s5cmd.
8f34fe0 
This is a clone of what I submitted as PR peak/action-setup-s5cmd#4 to the original `s5cmd` action author. Switch back to using theirs once they have accepted the PR.

Signed-off-by: Michael Herger <michael@herger.net>
@michaelherger
Copy link
Author

michaelherger commented Jan 31, 2025

I believe it would be a good moment to look into this, as the latest AWS CLI update has broken compatibility with other S3 "compatible" (or no more) services, like Cloudflare's R2 (https://www.cloudflarestatus.com/incidents/t5nrjmpxc1cj). s5cmd still does work, but is not easily installable on Windows runners.

@michaelherger
Copy link
Author

michaelherger commented Feb 12, 2025

FWIW: I've been using this for several weeks now, while Cloudflare wasn't compatible with the aws s3 CLI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sonmezonur sonmezonur Awaiting requested review from sonmezonur sonmezonur is a code owner automatically assigned from peak/big-data

@denizsurmeli denizsurmeli Awaiting requested review from denizsurmeli denizsurmeli is a code owner automatically assigned from peak/big-data

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@michaelherger @mherger